szaszm commented on code in PR #1385:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1385#discussion_r943499085
##########
METRICS.md:
##########
@@ -46,77 +46,88 @@ To use the publisher a port should also be configured where
the metrics will be
nifi.metrics.publisher.PrometheusMetricsPublisher.port=9936
-The last option defines which metric classes should be exposed through the
metrics publisher in configured with a comma separated value:
+The following option defines which metric classes should be exposed through
the metrics publisher in configured with a comma separated value:
# in minifi.properties
nifi.metrics.publisher.metrics=QueueMetrics,RepositoryMetrics,GetFileMetrics,DeviceInfoNode,FlowInformation
+An agent identifier should also be defined to identify which agent the metric
is exposed from. If not set the hostname is used as the identifier.
Review Comment:
I'm not great at english grammar, but I feel like a comma is missing from
there.
```suggestion
An agent identifier should also be defined to identify which agent the
metric is exposed from. If not set, the hostname is used as the identifier.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
