lordgamez commented on code in PR #1398:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1398#discussion_r951180672
##########
.github/workflows/ci.yml:
##########
@@ -151,13 +151,20 @@ jobs:
run: cd build && make flake8
- id: files
uses: Ana06/[email protected]
+ continue-on-error: true
- name: clang-tidy
run: |
+ if [[ -n "${{ steps.files.outputs.all }}" ]]; then
+ FILES="${{ steps.files.outputs.all }}"
+ else
+ git fetch origin main && git checkout -b main origin/main || true
+ FILES=$(git diff --name-only main ${{ github.sha }} --)
Review Comment:
Well it's relative to the number of cpp files changed, so it can be long if
we do it for every single commit. I would stick with checking only the newly
changed files per pushes, as we will run on every file eventually on PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
