Lehel44 commented on code in PR #6310: URL: https://github.com/apache/nifi/pull/6310#discussion_r952323731
########## nifi-api/src/main/java/org/apache/nifi/annotation/behavior/DefaultRunDuration.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.annotation.behavior; + +import java.time.Duration; + +public enum DefaultRunDuration { + NO_BATCHING(0), + TWENTY_FIVE_MILLIS(25), + FIFTY_MILLIS(50), + ONE_HUNDRED_MILLIS(100), + TWO_HUNDRED_FIFTY_MILLIS(250), + FIVE_HUNDRED_MILLIS(500), + ONE_SECOND(1000), + TWO_SECONDS(2000); + + private final long millis; + + DefaultRunDuration(final long millis) { Review Comment: Thanks for the suggestion. I have ambivalent feeling about this since it makes the code less readable and I'm not convinced about the introduction of new future run duration intervals. However, it won't harm to make the code more extensible and give up a little bit of simplicity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
