lordgamez opened a new pull request, #1406: URL: https://github.com/apache/nifi-minifi-cpp/pull/1406
Two of the socket tests randomly fails sometimes with the error message `bind: Address already in use`: the SecureSocketGetTCPTestEmptyPass and the TLSServerSocketSupportedProtocolsTest tests. One of these tests uses the port `38776` and the other uses port `38778`. The common issue with these two ports is that both are in the default linux port range which is between 32768 and 60999. If other tests are run beside these two tests it is possible that the system assigns these two ports to the clients in other tests, thus when we try to initialize the servers, the port binding fails. We should change these two ports to be outside the default system port range to avoid this issue. https://issues.apache.org/jira/browse/MINIFICPP-1921 ------------------------------------------------ Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
