Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/43#discussion_r87827996
--- Diff:
minifi-nar-bundles/minifi-framework-bundle/minifi-framework-nar/pom.xml ---
@@ -34,51 +34,70 @@ limitations under the License.
<source.skip>true</source.skip>
</properties>
<dependencies>
- <!-- mark these nifi artifacts as provided since it is included in
the lib -->
+ <dependency>
+ <groupId>org.apache.nifi.minifi</groupId>
+ <artifactId>minifi-framework-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.nifi.minifi</groupId>
+ <artifactId>minifi-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+
+ <!-- NiFi Framework level dependencies -->
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-api</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-runtime</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-nar-utils</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-properties</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
- <groupId>org.apache.nifi.minifi</groupId>
- <artifactId>minifi-framework-core</artifactId>
- <scope>provided</scope>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-security</artifactId>
+ <scope>compile</scope>
+ <version>1.0.0</version>
</dependency>
<dependency>
- <groupId>org.apache.nifi</groupId>
- <artifactId>nifi-administration</artifactId>
- <scope>provided</scope>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
</dependency>
<dependency>
- <groupId>org.apache.nifi.minifi</groupId>
- <artifactId>minifi-api</artifactId>
- <scope>provided</scope>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-servlet</artifactId>
</dependency>
<dependency>
- <groupId>org.apache.nifi</groupId>
- <artifactId>nifi-framework-core</artifactId>
- <scope>provided</scope>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-webapp</artifactId>
--- End diff --
Why are Jetty deps being added to the MiNiFi-framework-nar? I don't see any
other changes to the module that would warrant the additions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
