gresockj commented on code in PR #5369:
URL: https://github.com/apache/nifi/pull/5369#discussion_r957387855


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/FlowFromDOMFactory.java:
##########
@@ -148,6 +151,21 @@ public static ReportingTaskDTO getReportingTask(final 
Element element, final Pro
         return dto;
     }
 
+    public static ParameterProviderDTO getParameterProvider(final Element 
element, final PropertyEncryptor encryptor, final FlowEncodingVersion 
flowEncodingVersion) {
+        final ParameterProviderDTO dto = new ParameterProviderDTO();
+
+        dto.setId(getString(element, "id"));
+        dto.setName(getString(element, "name"));
+        dto.setComments(getString(element, "comment"));

Review Comment:
   Interesting.. this looks like an inconsistency between the various 
components.  For example, Port serializes this as "comments", but Processor 
serializes it as "comments".  I'll stick with "comment" since this is what 
Processor, ControllerService, and ReportingTask use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to