markobean commented on code in PR #6254:
URL: https://github.com/apache/nifi/pull/6254#discussion_r961693664
##########
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/script/ScriptingComponentHelper.java:
##########
@@ -265,7 +265,11 @@ public void setupVariables(final PropertyContext context) {
scriptEngineName = context.getProperty(SCRIPT_ENGINE).getValue();
scriptPath =
context.getProperty(ScriptingComponentUtils.SCRIPT_FILE).evaluateAttributeExpressions().getValue();
scriptBody =
context.getProperty(ScriptingComponentUtils.SCRIPT_BODY).getValue();
- modules =
context.getProperty(ScriptingComponentUtils.MODULES).evaluateAttributeExpressions().asResources().flattenRecursively();
+ if (scriptEngineName.equals("python")) {
Review Comment:
Suggest you make this case-insensitive allowing some future-proofing. I see
other engines start with a capital.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
