dan-s1 commented on code in PR #6254:
URL: https://github.com/apache/nifi/pull/6254#discussion_r961806190
##########
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/script/ScriptingComponentHelper.java:
##########
@@ -265,7 +265,11 @@ public void setupVariables(final PropertyContext context) {
scriptEngineName = context.getProperty(SCRIPT_ENGINE).getValue();
scriptPath =
context.getProperty(ScriptingComponentUtils.SCRIPT_FILE).evaluateAttributeExpressions().getValue();
scriptBody =
context.getProperty(ScriptingComponentUtils.SCRIPT_BODY).getValue();
- modules =
context.getProperty(ScriptingComponentUtils.MODULES).evaluateAttributeExpressions().asResources().flattenRecursively();
+ if (scriptEngineName.equals("python")) {
Review Comment:
Not sure that is necessary as code in
[ScriptRunnerFactory](https://github.com/NissimShiman/nifi/blob/NIFI-10287/nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/script/ScriptRunnerFactory.java#L55)
uses lowercase. I would though pattern after that class and have if statement
read as
`if ("python".equals(scriptEngineName))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
