hawko2600 commented on code in PR #6294:
URL: https://github.com/apache/nifi/pull/6294#discussion_r962206304


##########
minifi/pom.xml:
##########
@@ -504,6 +504,11 @@ limitations under the License.
                 <artifactId>lzma-java</artifactId>
                 <version>1.3</version>
             </dependency>
+            <dependency>

Review Comment:
   The zstd license is already in the notice files as it is included in apache 
commons, which is how I'm effecting it. The jni component was either BSD or 
Apache license off the top of my head, also already included.
   
   I didn't have a free rpi to test the jni component on ARM, this is my 2nd 
concern (the first being I can't possibly test heap utilization of every 
possible data flow). That's what field testing is for 😊



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to