[ 
https://issues.apache.org/jira/browse/NIFI-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664890#comment-15664890
 ] 

ASF GitHub Bot commented on NIFI-3032:
--------------------------------------

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/1220

    NIFI-3032 Resolved issue where multiple invocations of NiFiProperties…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    
    …Loader.withKey() used cached key.
    
    Added unit tests and resources.
    
    NIFI-3032 Fixed bug in AESSensitivePropertyProvider#getIdentifierKey where 
the result was always the max available key size, not the size of the current 
key.
    Added unit test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-3032

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1220
    
----

----


> NiFiPropertiesLoader can cache stale key after migration
> --------------------------------------------------------
>
>                 Key: NIFI-3032
>                 URL: https://issues.apache.org/jira/browse/NIFI-3032
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>            Priority: Blocker
>              Labels: encryption, security
>             Fix For: 1.1.0
>
>
> [[email protected]] discovered an issue where the 
> {{NiFiPropertiesLoader}} can be initialized with a static 
> {{SensitivePropertyProviderFactory}} containing a specific {{key}}, and then 
> when {{NiFiPropertiesLoader.withKey()}} is called with a different key, the 
> factory is not refreshed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to