Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1220#discussion_r87884181
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/NiFiPropertiesLoader.java
---
@@ -158,9 +158,7 @@ private static String getDefaultProviderKey() {
}
private void initializeSensitivePropertyProviderFactory() {
- if (sensitivePropertyProviderFactory == null) {
- sensitivePropertyProviderFactory = new
AESSensitivePropertyProviderFactory(keyHex);
- }
+ sensitivePropertyProviderFactory = new
AESSensitivePropertyProviderFactory(keyHex);
--- End diff --
@alopresto won't this still have race conditions if more than one thread
does NiFiPropertiesLoader.withKey() at the same time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
