adamdebreceni commented on code in PR #1410:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1410#discussion_r963699187
##########
libminifi/include/utils/Id.h:
##########
@@ -126,12 +126,12 @@ class NonRepeatingStringGenerator {
std::string generate() {
return prefix_ + std::to_string(incrementor_++);
}
- uint64_t generateId() {
- return incrementor_++;
- }
+ uint64_t generateId() {
+ return incrementor_++;
+ }
private:
std::atomic<uint64_t> incrementor_{0};
- std::string
prefix_{std::to_string(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count())
+ "-"};
+ std::string prefix_{IdGenerator::getIdGenerator()->generate().to_string() +
"-"};
Review Comment:
what files are accessed in parallel? (the tests seem to create separate
temporary directories)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
