Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/43#discussion_r87866531
--- Diff: minifi-assembly/src/main/assembly/dependencies.xml ---
@@ -36,23 +36,38 @@
<exclude>minifi-bootstrap</exclude>
<exclude>minifi-resources</exclude>
<!-- Filter items introduced via transitive dependencies
that are provided in associated NARs -->
+
<exclude>org.apache.nifi:nifi-framework-core:1.0.0</exclude>
+ <exclude>zookeeper</exclude>
<exclude>spring-aop</exclude>
<exclude>spring-context</exclude>
- <exclude>spring-security-core</exclude>
<exclude>spring-beans</exclude>
+ <exclude>spring-expression</exclude>
<exclude>swagger-annotations</exclude>
<exclude>slf4j-log4j12</exclude>
<exclude>aspectjweaver</exclude>
<exclude>h2</exclude>
<exclude>netty</exclude>
<exclude>jaxb-impl</exclude>
- <exclude>httpclient</exclude>
<exclude>mail</exclude>
<exclude>log4j</exclude>
+ <exclude>lucene-analyzers-common</exclude>
<exclude>lucene-queryparser</exclude>
<exclude>commons-net</exclude>
+ <exclude>spring-context</exclude>
+ <exclude>spring-security-core</exclude>
</excludes>
</dependencySet>
+ <dependencySet>
+ <scope>runtime</scope>
+ <useProjectArtifact>false</useProjectArtifact>
+ <outputDirectory>lib</outputDirectory>
--- End diff --
This is to provide explicit inclusion of the following artifacts. I found
out the tough way that the include/exclude directives will do a simple pattern
matching. So nifi-framework-core also excludes minifi-framework-core given the
match. Will put a comment on this to clarify. Had one at some point, but got
lost to the sands of time and many iterations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
