exceptionfactory commented on code in PR #6304: URL: https://github.com/apache/nifi/pull/6304#discussion_r967370086
########## nifi-commons/nifi-vault-utils/src/main/java/org/apache/nifi/vault/hashicorp/HashiCorpVaultCommunicationService.java: ########## @@ -24,6 +25,10 @@ * @see <a href="https://www.vaultproject.io/";>https://www.vaultproject.io/</a> */ public interface HashiCorpVaultCommunicationService { + /** + * Tests the connection to Vault, throwing an exception if there was a problem connecting to the server. + */ + void testConnection(); Review Comment: Instead of having this as a void method, what about changing it to `getServerVersion()`, and return the `String` from `VaultHealth`? That would make it a little more useful, and serve the same purpose for testing connectivity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
