gresockj commented on code in PR #6392: URL: https://github.com/apache/nifi/pull/6392#discussion_r967666274
########## nifi-nar-bundles/nifi-aws-bundle/nifi-aws-parameter-providers/src/test/java/org/apache/nifi/parameter/aws/TestAwsSecretsManagerParameterProvider.java: ########## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.parameter.aws; + +import com.amazonaws.services.secretsmanager.AWSSecretsManager; +import com.amazonaws.services.secretsmanager.model.AWSSecretsManagerException; +import com.amazonaws.services.secretsmanager.model.GetSecretValueRequest; +import com.amazonaws.services.secretsmanager.model.GetSecretValueResult; +import com.amazonaws.services.secretsmanager.model.ListSecretsResult; +import com.amazonaws.services.secretsmanager.model.SecretListEntry; +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.nifi.components.ConfigVerificationResult; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.parameter.Parameter; +import org.apache.nifi.parameter.ParameterDescriptor; +import org.apache.nifi.parameter.ParameterGroup; +import org.apache.nifi.parameter.VerifiableParameterProvider; +import org.apache.nifi.reporting.InitializationException; +import org.apache.nifi.util.MockComponentLog; +import org.apache.nifi.util.MockConfigurationContext; +import org.apache.nifi.util.MockParameterProviderInitializationContext; +import org.junit.Test; +import org.mockito.ArgumentMatcher; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThrows; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.argThat; +import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.spy; +import static org.mockito.Mockito.when; + +public class TestAwsSecretsManagerParameterProvider { + final ObjectMapper objectMapper = new ObjectMapper(); + + final List<Parameter> mySecretParameters = Arrays.asList( + parameter("paramA", "valueA"), + parameter("paramB", "valueB"), + parameter("otherC", "valueOther"), + parameter("paramD", "valueD"), + parameter("nonSensitiveE", "valueE"), + parameter("otherF", "valueF") + ); + final List<Parameter> otherSecretParameters = Arrays.asList( + parameter("paramG", "valueG"), + parameter("otherH", "valueOther") + ); + final List<ParameterGroup> mockParameterGroups = Arrays.asList( + new ParameterGroup("MySecret", mySecretParameters), + new ParameterGroup("OtherSecret", otherSecretParameters) + ); + + private AwsSecretsManagerParameterProvider getParameterProvider() { + return spy(new AwsSecretsManagerParameterProvider()); + } + + private AWSSecretsManager mockSecretsManager(final List<ParameterGroup> mockGroup) { + final AWSSecretsManager secretsManager = mock(AWSSecretsManager.class); + + final ListSecretsResult listSecretsResult = mock(ListSecretsResult.class); + final List<SecretListEntry> secretList = mockGroup.stream() + .map(group -> new SecretListEntry().withName(group.getGroupName())) + .collect(Collectors.toList()); + when(listSecretsResult.getSecretList()).thenReturn(secretList); + when(secretsManager.listSecrets(any())).thenReturn(listSecretsResult); + + mockGroup.forEach(group -> { + final String groupName = group.getGroupName(); + final Map<String, String> keyValues = group.getParameters().stream().collect(Collectors.toMap( + param -> param.getDescriptor().getName(), + Parameter::getValue)); + final String secretString; + try { + secretString = objectMapper.writeValueAsString(keyValues); + final GetSecretValueResult result = new GetSecretValueResult().withName(groupName).withSecretString(secretString); + when(secretsManager.getSecretValue(argThat(matchesGetSecretValueRequest(groupName)))) + .thenReturn(result); + } catch (final JsonProcessingException e) { + // Ignore + } Review Comment: Since this is in a lambda, I'll just rethrow as an IllegalStateException -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
