markap14 commented on code in PR #6408:
URL: https://github.com/apache/nifi/pull/6408#discussion_r968916012
##########
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/params/SetParam.java:
##########
@@ -88,7 +88,7 @@ public VoidResult doExecute(final NiFiClient client, final
Properties properties
throw new IllegalArgumentException("A parameter value is required
when creating a new parameter");
}
- if (existingParam.isPresent() &&
existingParam.get().getValue().equals(paramValue)) {
Review Comment:
Yeah sorry, @nandorsoma , I didn't mean to imply that settings to null via
CLI should work now, or that we should support it in this Jira. Just that
`Objects.equals` makes the most sense, in order to consider the possibility of
either value being null :) I don't think we need to address the issue of
issuing null's in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
