bejancsaba commented on code in PR #6375:
URL: https://github.com/apache/nifi/pull/6375#discussion_r969448783


##########
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/C2HeartbeatFactory.java:
##########
@@ -225,4 +234,27 @@ private File getConfDirectory() {
 
         return confDirectory;
     }
+
+    private String calculateManifestHash(List<Bundle> loadedBundles) {

Review Comment:
   You are absolutely right. For now I would leave it as is and as soon as the 
next extension comes in we can extract the logic at that point. Are you ok with 
this approach?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to