arpadboda commented on code in PR #6344:
URL: https://github.com/apache/nifi/pull/6344#discussion_r973208883
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java:
##########
@@ -382,12 +368,11 @@ private WriteStream createWriteStream() {
}
protected BigQueryWriteClient createWriteClient(GoogleCredentials
credentials) {
- BigQueryWriteClient client = null;
+ BigQueryWriteClient client;
try {
client =
BigQueryWriteClient.create(BigQueryWriteSettings.newBuilder().setCredentialsProvider(FixedCredentialsProvider.create(credentials)).build());
- } catch (IOException e) {
- getLogger().error("Failed to create Big Query Write Client for
writing due to {}", new Object[] {e});
- setupException.set(e);
+ } catch (Exception e) {
+ throw new ProcessException("Failed to create Big Query Write
Client for writing due to", e);
Review Comment:
Okay, this is fine, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
