bbende commented on PR #6435: URL: https://github.com/apache/nifi/pull/6435#issuecomment-1252863814
@Lehel44 ah thanks for pointing that out! I missed the use of `JsonTreeRowRecordReader` when making this change, and since I could only verify selecting a reader and oauth service and not actually run the processor, I suspect this change will cause a CNF exception at runtime. Ideally I think we should strive for NAR dependencies to be used primarily for API NARs. Meaning for a processor to depend on a service API that it needs, or for implementing a service API, but not really for accessing implementation code in another NAR. Usually this can be achieved by factoring out some common code to a shared JAR that can be used in multiple NARs, but I'm not sure that works easily in this case. A similar situation exists with `nifi-snowflake-nar` having a dependency on `nifi-dbcp-service-nar`, instead of depending on just the DBCP API from `nifi-standard-services-api-nar`. This was because `SnowflakeComputingConnectionPool extends DBCPConnectionPool` but I think it would be preferable to factor out some kind of shared `AbstractConnectionPool` that they both extend from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
