turcsanyip commented on code in PR #6452:
URL: https://github.com/apache/nifi/pull/6452#discussion_r981024048
##########
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/resources/docs/org.apache.nifi.processors.hubspot.GetHubSpot/additionalDetails.html:
##########
@@ -32,5 +32,13 @@ <h2>Incremental Loading</h2>
last run time of the processor are processed. The processor state can be
reset in the context menu. The incremental loading
is based on the objects last modified time.
</p>
+<p>
+ There is no deletion tolerance in the current implementation. Some objects
may be omitted if any object is deleted between fetching two pages.
Review Comment:
I think it rather belongs to the `Paging` section so I would move it there.
Also, I would mention that the deletion tolerance issue is due to the
limitations of the HubSpot API. Something like this:
```suggestion
<p>
Due to the page handling mechanism of the HubSpot API, parallel
deletions are not supported. Some objects may be omitted if any object is
deleted between fetching two pages.
```
##########
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java:
##########
@@ -116,17 +116,18 @@ public class GetHubSpot extends AbstractProcessor {
" the previous run time and the current time (optionally
adjusted by the Incremental Delay property).")
.required(true)
.allowableValues("true", "false")
- .defaultValue("false")
+ .defaultValue("true")
.build();
static final PropertyDescriptor INCREMENTAL_DELAY = new
PropertyDescriptor.Builder()
.name("incremental-delay")
.displayName("Incremental Delay")
.description(("The ending timestamp of the time window will be
adjusted earlier by the amount configured in this property." +
" For example, with a property value of 10 seconds, an
ending timestamp of 12:30:45 would be changed to 12:30:35." +
- " Set this property to avoid missing objects when the
clock of your local machines and HubSpot servers' clock are not in sync."))
+ " Set this property to avoid missing objects when the
clock of your local machines and HubSpot servers' clock are not in sync" +
+ " and to protect against HubSpot's mechanism that changes
last updated dates after object creation."))
Review Comment:
```suggestion
" and to protect against HubSpot's mechanism that
changes last updated timestamps after object creation."))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
