NissimShiman commented on code in PR #6254:
URL: https://github.com/apache/nifi/pull/6254#discussion_r983903112
##########
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/java/org/apache/nifi/processors/script/TestExecuteJython.java:
##########
@@ -61,6 +67,83 @@ public void
testReadFlowFileContentAndStoreInFlowFileAttributeWithScriptBody() t
result.get(0).assertAttributeEquals("from-content", "test content");
}
+ /**
+ * Tests a Jython script that references an outside python module
+ *
+ */
+ @Test
+ public void testAccessModuleAndStoreInFlowFileAttributeWithScriptBody() {
+ runner.setValidateExpressionUsage(false);
+
runner.setProperty(scriptingComponent.getScriptingComponentHelper().SCRIPT_ENGINE,
"python");
+ runner.setProperty(ScriptingComponentUtils.MODULES,
"target/test/resources/jython/");
+ runner.setProperty(ScriptingComponentUtils.SCRIPT_BODY,
+ "from org.apache.nifi.processors.script import ExecuteScript\n"
+ + "from test_external_module import ExternalModule\n"
+ + "externalModule = ExternalModule()\n"
+ + "flowFile = session.get()\n"
+ + "flowFile = session.putAttribute(flowFile, \"key\",
externalModule.testHelloWorld())\n"
+ + "session.transfer(flowFile,
ExecuteScript.REL_SUCCESS)");
+
+ runner.assertValid();
+ runner.enqueue("test content".getBytes(StandardCharsets.UTF_8));
+ runner.run();
+
+ runner.assertAllFlowFilesTransferred(ExecuteScript.REL_SUCCESS, 1);
+ final List<MockFlowFile> result =
runner.getFlowFilesForRelationship(ExecuteScript.REL_SUCCESS);
+ result.get(0).assertAttributeEquals("key", "helloWorld");
+ }
+
+
+ /**
+ * Tests a Jython script when adding comma separated list of all existing
directories from PYTHONPATH
+ * as value for {@link ScriptingComponentUtils} MODULES property.
+ *
+ * @throws Exception If PYTHONPATH cannot be retrieved.
+ */
+ @Test
+ @EnabledOnOs(OS.LINUX)
+ public void
testAccessPythonPackageModulesAndStoreInFlowFileAttributeWithScriptBody()
throws Exception {
+ String attributeName = "key";
+ String attributeValue = "helloWorld";
+ runner.setValidateExpressionUsage(false);
+
runner.setProperty(scriptingComponent.getScriptingComponentHelper().SCRIPT_ENGINE,
"python");
+ runner.setProperty(ScriptingComponentUtils.MODULES,
+ String.join(",", getExistingPythonPathModuleDirectories()));
+ runner.setProperty(ScriptingComponentUtils.SCRIPT_BODY,
+ "from org.apache.nifi.processors.script import ExecuteScript\n"
+ + "flowFile = session.get()\n"
+ + "flowFile = session.putAttribute(flowFile," + "\""
+ attributeName + "\", '" + attributeValue + "')\n"
+ + "session.transfer(flowFile,
ExecuteScript.REL_SUCCESS)");
+
+ runner.assertValid();
+ runner.enqueue("test content".getBytes(StandardCharsets.UTF_8));
+ runner.run();
+
+ runner.assertAllFlowFilesTransferred(ExecuteScript.REL_SUCCESS, 1);
+ final List<MockFlowFile> result =
runner.getFlowFilesForRelationship(ExecuteScript.REL_SUCCESS);
+ result.get(0).assertAttributeEquals(attributeName, attributeValue);
+ }
+
+ /**
+ * Method which retrieves the PYTHONPATH and builds a java.util.List of
existing directories on the PYTHONPATH.
+ * This method uses java.lang.ProcessBuilder and java.lang.Process to
execute python to obtain the PYTHONPATH.
+ *
+ * @return java.util.List of existing directories on PYTHONPATH.
+ * @throws Exception If an error occurs when executing a java.lang.Process.
+ */
+ List<String> getExistingPythonPathModuleDirectories() throws Exception{
+ String pathDelimiter = ",";
+ ProcessBuilder processBuilder = new ProcessBuilder();
+ processBuilder.command("python", "-c", "import sys; print('" +
pathDelimiter + "'.join(sys.path))");
Review Comment:
@exceptionfactory This is a very good observation. Just checked in code
that should handle this.
One of the ci/cd jobs didn't finish for one the builds (i.e. timed out
after 2 hours), but the others finished OK so we should be good there
Thank you very much for looking at this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
