[ 
https://issues.apache.org/jira/browse/NIFI-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667805#comment-15667805
 ] 

ASF GitHub Bot commented on NIFI-3040:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/1224

    NIFI-3040: Fixed bug where we were generating a RepositoryRecord with…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    
    … an 'UPDATE' type instead of a 'CREATE' time for Replay of FlowFiles. This 
caused FlowFile to have no attributes when restored from the FlowFile 
Repository.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-3040

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1224
    
----
commit 8dbb2eb52582fd5da7a92a29fa8b0169cc5fa9b4
Author: Mark Payne <[email protected]>
Date:   2016-11-15T17:59:02Z

    NIFI-3040: Fixed bug where we were generating a RepositoryRecord with an 
'UPDATE' type instead of a 'CREATE' time for Replay of FlowFiles. This caused 
FlowFile to have no attributes when restored from the FlowFile Repository.

----


> Unable to generate Provenance Event because FlowFile UUID is not set
> --------------------------------------------------------------------
>
>                 Key: NIFI-3040
>                 URL: https://issues.apache.org/jira/browse/NIFI-3040
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.1.0
>
>
> If I view a Provenance Event and click the Replay button, all works as 
> expected, if NiFi continues to run. However, if I replay a FlowFile and leave 
> the FlowFile in the queue while NiFi is restarted, upon restart I see the 
> following error in the log when trying to process the FlowFile:
> 2016-11-15 12:40:21,658 ERROR [Timer-Driven Process Thread-4] 
> o.a.n.c.r.StandardProvenanceReporter Failed to generate Provenance Event due 
> to java.lang.IllegalStateException: Cannot create Provenance Event Record 
> because FlowFile UUID is not set
> 2016-11-15 12:40:21,664 WARN [Timer-Driven Process Thread-4] 
> o.a.n.c.r.StandardProcessSession Unable to generate Provenance Event for 
> StandardFlowFileRecord[uuid=<null>,claim=StandardContentClaim 
> [resourceClaim=StandardResourceClaim[id=1479231329248-1, container=default, 
> section=1], offset=0, length=10240],offset=0,name=<null>,size=10240] on 
> behalf of UpdateAttribute[id=69080060-0158-1000-4b41-9b0e329b0c59] due to {}
> java.lang.IllegalStateException: Cannot create Provenance Event Record 
> because FlowFile UUID is not set
>         at 
> org.apache.nifi.provenance.StandardProvenanceEventRecord$Builder.assertSet(StandardProvenanceEventRecord.java:723)
>  ~[nifi-data-provenance-utils-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.provenance.StandardProvenanceEventRecord$Builder.build(StandardProvenanceEventRecord.java:744)
>  ~[nifi-data-provenance-utils-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.provenance.StandardProvenanceEventRecord$Builder.build(StandardProvenanceEventRecord.java:401)
>  ~[nifi-data-provenance-utils-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.repository.StandardProvenanceReporter.generateDropEvent(StandardProvenanceReporter.java:104)
>  ~[nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.repository.StandardProcessSession.checkpoint(StandardProcessSession.java:255)
>  [nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.repository.StandardProcessSession.commit(StandardProcessSession.java:304)
>  [nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:28)
>  [nifi-api-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1089)
>  [nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:136)
>  [nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
>  [nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:132)
>  [nifi-framework-core-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]
>         at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_60]
>         at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
> [na:1.8.0_60]
>         at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_60]
>         at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>  [na:1.8.0_60]
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_60]
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_60]
>         at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to