MikeThomsen commented on code in PR #6487:
URL: https://github.com/apache/nifi/pull/6487#discussion_r988462902
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml:
##########
@@ -204,181 +215,42 @@
<activation>
<activeByDefault>false</activeByDefault>
</activation>
+ <properties>
+ <elastic_docker_image>7.17.6</elastic_docker_image>
+ </properties>
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
+ <configuration>
+ <systemPropertyVariables>
+
<elastic.docker.image>docker.elastic.co/elasticsearch/elasticsearch:${elastic_docker_image}</elastic.docker.image>
+ </systemPropertyVariables>
+ </configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>
-
- <profile>
- <!-- use with elasticsearch-oss only (-default can be used if
x-pack-ml permissions fixed) -->
- <id>elasticsearch-6</id>
- <activation>
- <activeByDefault>false</activeByDefault>
- </activation>
- <properties>
- <es.int.version>6.8.23</es.int.version>
- <es.int.type.name>_doc</es.int.type.name>
- <es.int.script.name>setup-6.script</es.int.script.name>
- <es.int.path.conf />
- </properties>
- </profile>
<profile>
- <!-- use with elasticsearch-oss or elasticsearch-default -->
- <id>elasticsearch-7</id>
- <activation>
- <activeByDefault>false</activeByDefault>
- </activation>
+ <id>elastic5</id>
<properties>
- <es.int.version>7.10.2</es.int.version>
- <es.int.script.name>setup-7.script</es.int.script.name>
- <es.int.type.name />
- <es.int.path.conf />
+ <elastic_docker_image>5.6</elastic_docker_image>
Review Comment:
I'm not sure about the arm64, but that shouldn't be a blocker because arm64
support in NiFi is still a work in progress. As for the licensing issues, I
don't see why we would since elastic makes them freely available for
demonstration and evaluation purposes. We're also not redistributing them or
anything like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
