malthe commented on PR #6467: URL: https://github.com/apache/nifi/pull/6467#issuecomment-1270636734
@exceptionfactory, I started out extending the existing user group provider for Azure but ultimately thought that perhaps it is confusing to users that the same component has these two quite different capabilities. That said, specifying "Object ID" could enable the retrieval of app roles as an optional configuration for the existing AzureGraphUserGroupProvider. In fact, in both cases, Azure Graph API is used (just quite differently). But then what about the various existing options such as group filter? Today it is a required option because it is expected that we'll be querying for users and groups. While one could solve this by having a strategy property, perhaps one wants both modes enabled at the same time. While specifying "Object ID" could be the enabler for retrieving app roles, what would be the _disabler_ for trying to retrieve users and groups? I came to the conclusion that perhaps it's simply because these two user group providers are different enough to warrant their own classes. But I don't feel very strongly about this. Perhaps there is one caveat which is that I have used mocking for testing the provider while the tests for AzureGraphUserGroupProvider actually make calls to the service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
