adamdebreceni commented on code in PR #1429:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1429#discussion_r1000197426
##########
libminifi/src/core/ProcessSession.cpp:
##########
@@ -296,7 +296,7 @@ void ProcessSession::append(const
std::shared_ptr<core::FlowFile> &flow, const i
size_t stream_size_before_callback = stream->size();
// this prevents an issue if we write, above, with zero length.
if (stream_size_before_callback > 0)
- stream->seek(stream_size_before_callback + 1);
+ stream->seek(stream_size_before_callback);
Review Comment:
yes, unclear why we seek to `size + 1` instead of `size`, but it has been
like this since the beginning, since `BufferStream::seek` does not affect write
only read it was basically noop while with `FileStream` this is a problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
