markap14 commented on code in PR #6557:
URL: https://github.com/apache/nifi/pull/6557#discussion_r1000666325


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/mapping/NiFiRegistryFlowMapper.java:
##########
@@ -782,6 +782,7 @@ public VersionedRemoteProcessGroup 
mapRemoteProcessGroup(final RemoteProcessGrou
         rpg.setProxyHost(remoteGroup.getProxyHost());
         rpg.setProxyPort(remoteGroup.getProxyPort());
         rpg.setProxyUser(remoteGroup.getProxyUser());
+        rpg.setProxyPassword(encrypt(remoteGroup.getProxyPassword()));

Review Comment:
   This will always include the proxy password, which we don't want. We only 
want to include the proxy password if 
`flowMappingOptions.isMapSensitiveConfiguration()` is true. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to