michael81877 commented on PR #6560: URL: https://github.com/apache/nifi/pull/6560#issuecomment-1287187904
I could be off base here, so please correct me if i'm wrong. I'm just trying to understand the concerns completely. If i'm not mistaken, this change doesn't affect the startup of a standalone node. That's [handled separately](https://github.com/apache/nifi/blob/a5d93d96a30b3af73146e4b3c2a36a86332bb774/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java#L554-L564) using the same `BundleUpdateStrategy` strategy proposed in this PR. This PR only affects the strategy used when a node joins a cluster. Additionally, it seems like protocol versions are negotiated for things like [load balancing](https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server/StandardLoadBalanceProtocol.java#L125) and site-to-site [1, 2]. Wouldn't that prevent any unexpected issues with communications? In the scenario where one node could be missing or has an outdated version of an extension that other nodes in the cluster have, i believe that would be considered an error by the operator, right? In cases where deployment environments are entirely version controlled, these sorts of issues would seem unlikely to present themselves. Perhaps a flow requires a version of an extension that a new NiFi version doesn't contain, but i would also consider this an error by the operator. Since we know NiFi is capable of it rolling upgrades, is there an alternative recommended approach? [1] [socket site-to-site version negotiation](https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/protocol/socket/SocketFlowFileServerProtocol.java#L52) [2] [http site-to-site version negotiation](https://github.com/apache/nifi/blob/main/nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/http/TransportProtocolVersionNegotiator.java) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
