nandorsoma commented on code in PR #6443:
URL: https://github.com/apache/nifi/pull/6443#discussion_r1002150279
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java:
##########
@@ -121,18 +146,47 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
if (createContainer && !containerClient.exists()) {
containerClient.create();
}
- BlobClient blobClient = containerClient.getBlobClient(blobName);
+ BlobClient blobClient = containerClient.getBlobClient(blobName);
+ final BlobRequestConditions blobRequestConditions = new
BlobRequestConditions();
+ Map<String, String> attributes = new HashMap<>();
Review Comment:
Sorry I wasn't clear. It's my bad. I meant when execution jumps to the catch
block and recovers in case of `ignore` resolution. But meanwhile, I realized
since `ignore` is not the default behavior, it won't break anything.
Nevertheless, I still have issues with the two properties I mentioned
previously. Applying `mime.type` and `lang` before the upload is not ok because
it can fail, and then these values don't make sense. I think it's better to
apply them after upload, and then we can get the values from the client, which
is more precise.
The test you mentioned was written when ignore wasn't in the game; that's
why it is probably failing. But I think we can modify it accordingly. Which
test is that?
Also, applying the other three attributes before uploading could have a
purpose. Still, if we don't have a use case for that, then I think it would be
clearer to apply all attributes after a successful upload, like in the original
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
