dan-s1 commented on code in PR #6574: URL: https://github.com/apache/nifi/pull/6574#discussion_r1005823992
########## nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/IsJsonEvaluator.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.attribute.expression.language.evaluation.functions; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.attribute.expression.language.EvaluationContext; +import org.apache.nifi.attribute.expression.language.evaluation.BooleanEvaluator; +import org.apache.nifi.attribute.expression.language.evaluation.BooleanQueryResult; +import org.apache.nifi.attribute.expression.language.evaluation.Evaluator; +import org.apache.nifi.attribute.expression.language.evaluation.QueryResult; + +import java.io.IOException; + +public class IsJsonEvaluator extends BooleanEvaluator { + private static final ObjectMapper MAPPER = new ObjectMapper(); + private final Evaluator<String> subject; + + public IsJsonEvaluator(Evaluator<String> subject) { + this.subject = subject; + } + + @Override + public QueryResult<Boolean> evaluate(EvaluationContext evaluationContext) { + final String subjectValue = subject.evaluate(evaluationContext).getValue(); Review Comment: @exceptionfactory Correct me if I am wrong but it seems JsonNode is associated more with implementation as that is what Jackson names its object. To me at least, isJsonNode would indicate how this is implemented and is not as important to the end user who might not even know what JsonNode is. Hence if you don't mind, I will leave the method as isJson, implement the change suggested by @MikeThomsen and document the purpose of the function indicating what it can and what it cannot do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
