fgerlits commented on code in PR #1435:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1435#discussion_r1006636353
##########
libminifi/test/unit/ProcessSessionTests.cpp:
##########
@@ -126,3 +132,44 @@ TEST_CASE("ProcessSession::read can read zero length
flowfiles without crash", "
ContentRepositoryDependentTests::testReadFromZeroLengthFlowFile(std::make_shared<core::repository::VolatileContentRepository>());
ContentRepositoryDependentTests::testReadFromZeroLengthFlowFile(std::make_shared<core::repository::FileSystemRepository>());
}
+
+struct VolatileFlowFileRepositoryTestAccessor {
+ METHOD_ACCESSOR(flush);
+};
+
+class TestVolatileFlowFileRepository : public
core::repository::VolatileFlowFileRepository {
+ public:
+ explicit TestVolatileFlowFileRepository(std::string name) :
core::SerializableComponent(std::move(name)) {}
Review Comment:
why is this not
```suggestion
explicit TestVolatileFlowFileRepository(std::string name) :
core::repository::VolatileFlowFileRepository(std::move(name)) {}
```
?
##########
libminifi/include/core/repository/VolatileRepository.h:
##########
@@ -256,7 +257,7 @@ bool VolatileRepository<KeyType, RepositoryType>::Put(const
KeyType& key, const
} while (!updated);
current_size_ += size;
- logger_->log_debug("VolatileRepository -- put %u %u", current_size_.load(),
current_index_.load());
+ logger_->log_debug("VolatileRepository -- put %zu " PRIu32,
current_size_.load(), current_index_.load());
Review Comment:
there is a `%` missing before `PRIu32`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
