adamdebreceni commented on code in PR #1444:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1444#discussion_r1011698031
##########
extensions/http-curl/processors/InvokeHTTP.cpp:
##########
@@ -334,6 +334,10 @@ void InvokeHTTP::onTriggerWithClient(const
std::shared_ptr<core::ProcessContext>
logger_->log_debug("onTrigger InvokeHTTP with %s to %s",
client.getRequestMethod(), client.getURL());
+ const auto remove_callback_from_client_at_exit = gsl::finally([&client] {
+ client.setUploadCallback({});
Review Comment:
I feel like this is the responsibility of `ResourceQueue` and should be
handled in `ResourceQueue::returnResource`, what I am thinking is a `resetter:
std::function<void(ResourceType&)>` (probably an extra constructor argument to
`ResourceQueue`) which when set would be called in `returnResource`, what do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
