[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1436: MINIFICPP-1963 improve exception logging

[GitBox]

szaszm commented on code in PR #1436:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1436#discussion_r1011979667


##########
libminifi/src/SchedulingAgent.cpp:
##########
@@ -115,11 +115,11 @@ bool SchedulingAgent::onTrigger(core::Processor* 
processor, const std::shared_pt
     processor->onTrigger(processContext, sessionFactory);
     processor->decrementActiveTask();
   } catch (std::exception &exception) {
-    logger_->log_debug("Caught Exception %s", exception.what());
+    logger_->log_debug("Caught Exception during SchedulingAgent::onTrigger, 
type: %s, what: %s", typeid(exception).name(), exception.what());

Review Comment:
   fixed in 
[992be3f](https://github.com/apache/nifi-minifi-cpp/pull/1436/commits/992be3fa4947c4980812cb844c1d27e15e02e29a)



##########
libminifi/src/SchedulingAgent.cpp:
##########
@@ -115,11 +115,11 @@ bool SchedulingAgent::onTrigger(core::Processor* 
processor, const std::shared_pt
     processor->onTrigger(processContext, sessionFactory);
     processor->decrementActiveTask();
   } catch (std::exception &exception) {
-    logger_->log_debug("Caught Exception %s", exception.what());
+    logger_->log_debug("Caught Exception during SchedulingAgent::onTrigger, 
type: %s, what: %s", typeid(exception).name(), exception.what());
     processor->yield(admin_yield_duration_);
     processor->decrementActiveTask();
   } catch (...) {
-    logger_->log_debug("Caught Exception during SchedulingAgent::onTrigger");
+    logger_->log_debug("Caught Exception during SchedulingAgent::onTrigger, 
type: %s", getCurrentExceptionTypeName());

Review Comment:
   fixed in 
[992be3f](https://github.com/apache/nifi-minifi-cpp/pull/1436/commits/992be3fa4947c4980812cb844c1d27e15e02e29a)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org