adam-markovics commented on code in PR #1443:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1011988154
##########
libminifi/include/core/ProcessContext.h:
##########
@@ -246,14 +238,14 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
return initialized_;
}
- static constexpr char const* DefaultStateManagerProviderName =
"defaultstatemanagerprovider";
+ static constexpr char const* DefaultStateStorageName = "defaultstatestorage";
Review Comment:
I don't think so. It's just used as an ID (line 264 and 282), not compared
with anything coming from the config. Well, it could ruin your config it you
already had some other controller service with the ID of "defaultstatestorage",
but chances are really slim and easy to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
