dam4rus commented on code in PR #6584:
URL: https://github.com/apache/nifi/pull/6584#discussion_r1015154723
##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/AbstractDBCPConnectionPool.java:
##########
@@ -496,6 +499,15 @@ protected Driver getDriver(final String driverName, final
String url) {
}
}
+ /**
+ * Override in subclasses to provide connection properties to the data
source
+ *
+ * @return Key-value pairs that will be added as connection properties
+ */
+ protected Map<String, String> getConnectionProperties(final
ConfigurationContext context) {
Review Comment:
I'm not sure we want this to be an abstract method since returning an empty
Map seems like a sensible default to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
