szaszm commented on code in PR #1449:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1449#discussion_r1017846663
##########
extensions/libarchive/BinFiles.h:
##########
@@ -87,8 +87,10 @@ class Bin {
}
}
- if ((queued_data_size_ + flow->getSize()) > maxSize_ || (queue_.size() +
1) > maxEntries_)
+ if ((queued_data_size_ + flow->getSize()) > maxSize_ || (queue_.size() +
1) > maxEntries_) {
+ closed_ = true;
Review Comment:
Do you think it would make sense to penalize flow files that are larger than
the max group size? Currently if there is such a flow file, it will keep
flushing out all bins regardless of how "full" they are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
