adamdebreceni commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1018948690
##########
extensions/librdkafka/PublishKafka.cpp:
##########
@@ -266,8 +266,8 @@ class ReadCallback {
status_ = 0;
called_ = true;
- gsl_Expects(max_seg_size_ != 0 || (flow_size_ == 0 && "max_seg_size_ == 0
implies flow_size_ == 0"));
- // ^^ therefore checking max_seg_size_ == 0 handles both division by zero
and flow_size_ == 0 cases
+ gsl_Expects(max_seg_size_ != 0 || (flow_size_ == 0 && "max_message_size_
== 0 implies flow_size_ == 0"));
+ // ^^ therefore checking max_message_size_ == 0 handles both division by
zero and flow_size_ == 0 cases
Review Comment:
was this renamed by accident? the variable is still `max_seg_size_` so the
comments seem to be out of sync now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
