adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1020294046
##########
extensions/mqtt/processors/ConsumeMQTT.h:
##########
@@ -35,27 +36,35 @@
namespace org::apache::nifi::minifi::processors {
-#define MQTT_TOPIC_ATTRIBUTE "mqtt.topic"
-#define MQTT_BROKER_ATTRIBUTE "mqtt.broker"
-
class ConsumeMQTT : public processors::AbstractMQTTProcessor {
public:
explicit ConsumeMQTT(const std::string& name, const utils::Identifier& uuid
= {})
: processors::AbstractMQTTProcessor(name, uuid) {
- maxQueueSize_ = 100;
}
EXTENSIONAPI static constexpr const char* Description = "This Processor gets
the contents of a FlowFile from a MQTT broker for a specified topic. "
"The the payload of the MQTT message becomes content of a FlowFile";
+ EXTENSIONAPI static const core::Property Topic;
EXTENSIONAPI static const core::Property CleanSession;
+ EXTENSIONAPI static const core::Property CleanStart;
+ EXTENSIONAPI static const core::Property SessionExpiryInterval;
EXTENSIONAPI static const core::Property QueueBufferMaxMessage;
+ EXTENSIONAPI static const core::Property AttributeFromContentType;
+ EXTENSIONAPI static const core::Property TopicAliasMaximum;
+ EXTENSIONAPI static const core::Property ReceiveMaximum;
static auto properties() {
- return utils::array_cat(AbstractMQTTProcessor::properties(), std::array{
+ return utils::array_cat(AbstractMQTTProcessor::basicProperties(),
std::array{
Review Comment:
Yes, the order looks better, might make sense when on a web UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
