[
https://issues.apache.org/jira/browse/NIFI-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633866#comment-17633866
]
David Handermann commented on NIFI-10813:
-----------------------------------------
[~dstiegli1] That is correct, the initial approach to the JUnit 5 migration did
not include removing the {{public}} modifier from classes and methods. This
would be a helpful improvement, but it should probably come after all other
JUnit 4 tests have been migrated to JUnit 5.
If you would like to help convert any remaining JUnit 4 tests, that would be
great.
> Complete changes on NIFI Expression Language Unit Testing to be completely
> JUnit 5
> ----------------------------------------------------------------------------------
>
> Key: NIFI-10813
> URL: https://issues.apache.org/jira/browse/NIFI-10813
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> In the unit class
> nifi/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java,
> I noticed SonarLint is complaining regarding the class being public and the
> test methods being public since in JUnit 5 they can be anything but private.
> It is recommended to use package level as it improves the readability of
> code. This ticket is aimed on making TestQuery.java completely JUnit 5 by
> removing the public modifiers from the class and its methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
