[ 
https://issues.apache.org/jira/browse/NIFI-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633900#comment-17633900
 ] 

Daniel Stieglitz edited comment on NIFI-10813 at 11/14/22 3:54 PM:
-------------------------------------------------------------------

[~exceptionfactory] Are you referring to the Open and Unassigned subtasks in 
NIFI-9084? I see some which are Open but assigned with and without PRs.


was (Author: JIRAUSER294662):
[~exceptionfactory] Are you referring to the Open and Unassigned subtasks in 
NIFI-9084?

> Complete changes on NIFI Expression Language Unit Testing to be completely 
> JUnit 5
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-10813
>                 URL: https://issues.apache.org/jira/browse/NIFI-10813
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> In the unit class 
> nifi/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java,
>  I noticed SonarLint is complaining regarding the class being public and the 
> test methods being public since in JUnit 5 they can be anything but private.  
> It is recommended to use package level as it improves the readability of 
> code. This ticket is aimed on making TestQuery.java completely JUnit 5 by 
> removing the public modifiers from the class and its methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to