Lehel44 commented on code in PR #6650:
URL: https://github.com/apache/nifi/pull/6650#discussion_r1022157647
##########
nifi-api/src/main/java/org/apache/nifi/components/PropertyDescriptor.java:
##########
@@ -591,6 +606,38 @@ public Builder dependsOn(final PropertyDescriptor
property, final String firstDe
return dependsOn(property, dependentValues);
}
+ /**
+ * Establishes a relationship between this Property and the given
property by declaring that this Property is only relevant if the given Property
has a value equal to one of the given
+ * {@link DescribedValue} arguments.
Review Comment:
The naming "this Property" and "given property" is not trivial. I suggest
renaming it to "dependent" or "original" property" and "conditional property".
If this is agreeable, it'd apply to the remaining javadoc, too.
```suggestion
* Establishes a relationship between the original Property and the
conditional property by declaring that the original Property is only relevant
if the conditional Property value equals to one of the given
* {@link DescribedValue} arguments.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
