adam-markovics commented on code in PR #1447:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1447#discussion_r1024083843
##########
libminifi/include/core/ProcessSession.h:
##########
@@ -155,16 +156,25 @@ class ProcessSession : public ReferenceContainer {
std::shared_ptr<FlowFile> snapshot;
};
+ using Relationships = utils::ValueIdProvider<Relationship>;
+
+ Relationships relationships_;
Review Comment:
We only instantiate `ValueCompressor` with id being 8 bytes, so this
doesn't apply now. Also this member should be private as no subclasses use it,
so invalid pointer dereferencing is not possible (by someone else) if usage is
consistent within this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
