turcsanyip commented on code in PR #6649:
URL: https://github.com/apache/nifi/pull/6649#discussion_r1024921650


##########
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -108,10 +106,22 @@ public class PublishAMQP extends 
AbstractAMQPProcessor<AMQPPublisher> {
             .addValidator(StandardValidators.SINGLE_CHAR_VALIDATOR)
             .required(false)
             .build();
+
+    public static final PropertyDescriptor IGNORE_HEADER_WITH_NULL_VALUE = new 
PropertyDescriptor.Builder()

Review Comment:
   I agree with @thenatog that the property is not necessary and allowing the 
`null` header could be the only work mode. We did not introduce extra property 
for ignoring null headers in `ConsumeAMQP` either 
([NIFI-10317](https://issues.apache.org/jira/browse/NIFI-10317)).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to