turcsanyip commented on code in PR #6584: URL: https://github.com/apache/nifi/pull/6584#discussion_r1025237065
########## nifi-nar-bundles/nifi-snowflake-bundle/nifi-snowflake-processors/pom.xml: ########## @@ -0,0 +1,124 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>nifi-snowflake-bundle</artifactId> + <groupId>org.apache.nifi</groupId> + <version>1.19.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>nifi-snowflake-processors</artifactId> + <packaging>jar</packaging> + + <dependencies> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-api</artifactId> + <version>1.19.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> Review Comment: `nifi-api` comes as `provided` and with the right version from `dependencyManagement` so it is not needed to declare the version/scope here. The same in the other pom-s. ```suggestion <dependency> <groupId>org.apache.nifi</groupId> <artifactId>nifi-api</artifactId> </dependency> ``` ########## nifi-nar-bundles/nifi-snowflake-bundle/nifi-snowflake-processors/pom.xml: ########## @@ -0,0 +1,124 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>nifi-snowflake-bundle</artifactId> + <groupId>org.apache.nifi</groupId> + <version>1.19.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>nifi-snowflake-processors</artifactId> + <packaging>jar</packaging> + + <dependencies> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-api</artifactId> + <version>1.19.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-utils</artifactId> + <version>1.19.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-snowflake-services</artifactId> + <version>1.19.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-snowflake-services-api</artifactId> + <version>1.19.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>net.snowflake</groupId> + <artifactId>snowflake-ingest-sdk</artifactId> + <version>1.0.2-beta.3</version> + <scope>provided</scope> + </dependency> Review Comment: It would be worth mentioning in a comment that `snowflake-ingest-sdk` artifact incorporates `snowflake-jdbc` as well. `1.0.2-beta.6` is available in the meantime. ########## nifi-nar-bundles/nifi-snowflake-bundle/nifi-snowflake-services-api-nar/src/main/resources/META-INF/NOTICE: ########## @@ -0,0 +1,14 @@ +nifi-snowflake-services-api-nar +Copyright 2014-2022 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +************************** +Apache Software License v2 +************************** + + (ASLv2) Snowflake Ingest SDK + The following NOTICE information applies: + Snowflake Ingest SDK + Copyright (c) 2013-2016 Snowflake Computing, Inc. Review Comment: It needs to be added in the assembly notice as well. ########## nifi-nar-bundles/nifi-snowflake-bundle/nifi-snowflake-processors/src/main/resources/docs/org.apache.nifi.processors.snowflake.PutSnowflakeInternalStage/additionalDetails.html: ########## @@ -0,0 +1,43 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<!DOCTYPE html> +<html lang="en"> +<head> + <meta charset="utf-8"/> + <title>PutSnowflakeInternalStage</title> + <link rel="stylesheet" href="../../../../../css/component-usage.css" type="text/css"/> + <style> + h2 {margin-top: 4em} + h3 {margin-top: 3em} + td {text-align: left} + </style> +</head> +<body> + +<h1>PutSnowflakeInternalStage</h1> + +<h3>Description</h3> +<p> + The PutSnowflakeInternalStage processor can upload a file to a Snowflake internal stage. This stage needs to be set up in your Snowflake account. Review Comment: User / table stage have been introduced in the meantime. Please update the documentation. ########## nifi-nar-bundles/nifi-snowflake-bundle/nifi-snowflake-services-nar/src/main/resources/META-INF/NOTICE: ########## @@ -29,3 +29,15 @@ The following binary components are provided under the Apache Software License v The following NOTICE information applies: snowflake-jdbc Copyright (c) 2013-2018 Snowflake Computing, Inc. + Review Comment: I think `snowflake-jdbc` can be removed from the notice file because because we are depend on `snowflake-ingest-sdk`. Also from the assembly notice file. ########## nifi-nar-bundles/nifi-snowflake-bundle/nifi-snowflake-processors/src/main/resources/docs/org.apache.nifi.processors.snowflake.PutSnowflakeInternalStage/additionalDetails.html: ########## @@ -0,0 +1,43 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<!DOCTYPE html> +<html lang="en"> +<head> + <meta charset="utf-8"/> + <title>PutSnowflakeInternalStage</title> + <link rel="stylesheet" href="../../../../../css/component-usage.css" type="text/css"/> + <style> + h2 {margin-top: 4em} + h3 {margin-top: 3em} + td {text-align: left} + </style> +</head> +<body> + +<h1>PutSnowflakeInternalStage</h1> + +<h3>Description</h3> +<p> + The PutSnowflakeInternalStage processor can upload a file to a Snowflake internal stage. This stage needs to be set up in your Snowflake account. + See the documentation on how to set up an internal stage <a href="https://docs.snowflake.com/en/user-guide/data-load-local-file-system-create-stage.html";>here</a>. + The processor requires an upstream connection and the incoming FlowFiles' content will be uploaded to the stage. The attributes "filename" and "path" are used to provide a prefix and file name for your file in the stage. Review Comment: It has been changed to use UUID instead of filename+path in the meantime. Please update the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
