ChrisSamo632 commented on PR #6673: URL: https://github.com/apache/nifi/pull/6673#issuecomment-1319831563
Thanks for the work @kevdoran and additional reviews @exceptionfactory (and others). +1 from me, will get this merged. Just to follow-on from some of the threads above: - I still can't run the niti-toolkit-assembly tests on my AMD machine (changing the Maven memory settings haven't worked), but I'm happy that the tests do work on my Mac M1 (arm64) machine and for others on Intel/AMD, suggesting it's a setup issue for my machine - might investigate further and if I find something to change, I'll raise a separate PR/issue - `dockermaven` builds don't work on arm64 (Mac M1) due to the use of the spotify plugin, which is unfortunate but *not* a blocker for this PR as it wasn't the main goal nor is there a regression in build functionality; relevantly, the images once built *do* work on arm64 architectures, which is a big step forward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
