emiliosetiadarma commented on code in PR #6637:
URL: https://github.com/apache/nifi/pull/6637#discussion_r1027557958
##########
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessResource.java:
##########
@@ -687,7 +690,7 @@ public Response oidcExchange(@Context HttpServletRequest
httpServletRequest, @Co
return generateOkResponse(jwt).build();
}
- @DELETE
+ @GET
Review Comment:
Based on the specs
(https://openid.net/specs/openid-connect-rpinitiated-1_0.html), requests to the
OIDC logout endpoint should be made with a `GET` or `POST` request, not a
`DELETE` request. OIDC providers also support `GET` or `POST` request with the
logout endpoint (for instance KeyCloak:
https://github.com/keycloak/keycloak/blob/main/services/src/main/java/org/keycloak/protocol/oidc/endpoints/LogoutEndpoint.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
