ChrisSamo632 commented on code in PR #6701:
URL: https://github.com/apache/nifi/pull/6701#discussion_r1029384870
##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractJsonQueryElasticsearch.java:
##########
@@ -105,6 +105,10 @@
private String splitUpAggregations;
private boolean outputNoHits;
+ public boolean getOutputNoHits() {
Review Comment:
package-privte would be fine, not `public`
Personally I'd move the method lower down the class too rather than putting
it in the middle of the class field definitions... but that's more a personal
preference than anything so happy to ignore that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
