[ https://issues.apache.org/jira/browse/NIFI-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671910#comment-15671910 ]
ASF GitHub Bot commented on NIFI-3049: -------------------------------------- GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/1237 NIFI-3049 Fixes logging issues due to logback and log4j being on the … Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. …classpath Removed logback usage from classpath Added slf4j-log4j12 dependency in nifi-toolkit pom Added logback-classic exclusion for nifi-properties-loader used by nifi-toolkit-encrypt-config Updated log4j.properties logging pattern and logger config in nifi-toolkit-assembly and nifi-toolkit-zookeeper-migrator, filtering zookeeper messages below WARN Removed logback.groovy since log4j is the single logging implementation Updated ZooKeeperMigratorMain command line output to match standards established by other tools in nifi-toolkit You can merge this pull request into a Git repository by running: $ git pull https://github.com/jtstorck/nifi NIFI-3049 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1237 ---- commit 2cc5ce2c023fcdf770e05a33bbcfd78c682ff680 Author: Jeff Storck <jtsw...@gmail.com> Date: 2016-11-16T22:41:12Z NIFI-3049 Fixes logging issues due to logback and log4j being on the classpath Removed logback usage from classpath Added slf4j-log4j12 dependency in nifi-toolkit pom Added logback-classic exclusion for nifi-properties-loader used by nifi-toolkit-encrypt-config Updated log4j.properties logging pattern and logger config in nifi-toolkit-assembly and nifi-toolkit-zookeeper-migrator, filtering zookeeper messages below WARN Removed logback.groovy since log4j is the single logging implementation Updated ZooKeeperMigratorMain command line output to match standards established by other tools in nifi-toolkit ---- > ZooKeeper Migrator Toolkit addition has broken logging in NiFI Toolkit and > does not provide the correct command line usage output > --------------------------------------------------------------------------------------------------------------------------------- > > Key: NIFI-3049 > URL: https://issues.apache.org/jira/browse/NIFI-3049 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build > Affects Versions: 1.1.0 > Reporter: Jeff Storck > Assignee: Jeff Storck > > The ZooKeeper Migrator Toolkit has a dependency on ZooKeeper 3.4.6 which has > a hard dependecy on log4j, which conflicts with nifi-property-loader's > dependency on logback. When the toolkit runs, SLF4J finds two logging > implementations to bind to and complains, and according to SLF4J's > documentation, it is considered random which implementation SLF4J will use. > The command line output should be modified to adhere to the standard > established by the other tools in the toolkit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)