lordgamez opened a new pull request, #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461
This PR contains multiple changes and refactoring in the docker test environment: - Moved docker cluster specific classes to separate `cluster` directory under `test/integration` directory - minifi.properties and all additional configuration files are now mounted instead of building a separate image for every config - Added `MinifiOptions` to specify minifi deployment options like additional properties - New minifi test image is only build if additonal packages are needed (in case of SQL tests) - Removed inheritance hierarchy for `DockerTestCluster` - `SingleNodeDockerCluster` renamed to `ContainerStore` and only contains container deployment specific functionality - Extension specific checkers are extracted to separate checker classes - Docker communicator extracted for communicated with docker containers - Moved general container operations to `Container` base class - Flushing container logs in case of all assertion failures https://issues.apache.org/jira/browse/MINIFICPP-1983 ------------------------- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
