exceptionfactory commented on code in PR #6720: URL: https://github.com/apache/nifi/pull/6720#discussion_r1033838074
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/parameter/TestStandardParameterContext.java: ########## @@ -35,10 +34,12 @@ import java.util.Set; import static junit.framework.TestCase.assertTrue; Review Comment: This should be replaced with the Jupiter Assertions import. ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/parameter/TestStandardParameterContext.java: ########## @@ -20,7 +20,6 @@ import org.apache.nifi.controller.service.ControllerServiceNode; import org.apache.nifi.controller.service.ControllerServiceState; import org.apache.nifi.groups.ProcessGroup; -import org.junit.Assert; import org.junit.Test; Review Comment: This should be replaced with JUnit Jupiter Test ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/controller/repository/TestRingBufferEventRepository.java: ########## @@ -17,14 +17,17 @@ package org.apache.nifi.controller.repository; import org.apache.nifi.controller.repository.metrics.RingBufferEventRepository; -import org.junit.Assert; import org.junit.Test; Review Comment: This needs to be changed to JUnit Jupiter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
