ZhewenFu commented on code in PR #6596:
URL: https://github.com/apache/nifi/pull/6596#discussion_r1035539697
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/inheritance/MissingComponentsCheck.java:
##########
@@ -34,15 +35,15 @@ public FlowInheritability checkInheritability(final
DataFlow existingFlow, final
existingMissingComponents.removeAll(proposedFlow.getMissingComponents());
if (existingMissingComponents.size() > 0) {
- final String missingIds =
StringUtils.join(existingMissingComponents, ",");
+ final String missingIds =
StringUtils.join(existingMissingComponents.stream().sorted().collect(Collectors.toList()),
",");
Review Comment:
Hi, the current fix of using LinkedHashSet only fully solves the first test,
and the second test is still flaky so I left the sorting here. I have tried to
replace `HashSet` with `LinkedHashSet` on all the places where we check
`MissingComponenets` but the second test is still flaky in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
